Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate correct start slot for skipped epoch transition #1015

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Calculate correct start slot for skipped epoch transition #1015

merged 3 commits into from
Aug 10, 2023

Conversation

skunert
Copy link
Contributor

@skunert skunert commented Aug 10, 2023

Small followup to #991

  • Removes some assertions that no longer hold now that epochs can be skipped
  • When an epoch is skipped we need to adjust the starting slot of the next epoch

@skunert skunert requested a review from tomaka as a code owner August 10, 2023 13:49
tomaka
tomaka approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@tomaka tomaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good to me, although to honest Babe now feels over-engineered and has become hard to reason about.

@tomaka tomaka added this pull request to the merge queue Aug 10, 2023
Merged via the queue into smol-dot:main with commit 726dd51 Aug 10, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaka tomaka tomaka approved these changes

@lexnv lexnv lexnv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skunert @tomaka @lexnv