Don't require the genesis state for parachains #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #908
cc #864
When it comes to relay chains, it is mandatory for the chain spec to contain either the genesis state or a checkpoint, as otherwise it's not possible to verify warp sync proofs and in general not possible to sync at all.
When it comes to parachains, however, it is in principle possible to do with neither, as all the information we need is found in the relay chain.
However, before this PR, the restriction of having either the genesis state or checkpoint applied to both relay chains and parachains. Given that parachains can't have checkpoints, this has the consequence that the genesis state of parachains always had to be provided, and thus smoldot always had to build the runtime and calculate the state root, which uses a lot of CPU.
This PR fixes this.