Compile for wasm32-unknown instead of wasm32-wasi
#1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before this PR, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that no-std compatibility has more or less been achieved (cc #133), we no longer need to compile to
wasiand can instead switch towasm32-unknown-unknown.#91 was preventing this change, but the issue is now closed.
Switching to
wasm32-unknownpaves the way for #88 or #519, and has the advantage that it's more stable thanwasi. The bindings are also more clean. We no longer pin a specific version of Rust and no longer assume thatrustupis in PATH and no longer install things on the user's machine, which are all great things.The main disadvantage is that
printlnwill no longer work, which was sometimes useful for debugging.