Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the flow of execution of light-base/sync/relay #1383

Merged
merged 8 commits into from
Nov 22, 2023
Merged

Simplify the flow of execution of light-base/sync/relay #1383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
602b43f
Inline `process_foreground_messages`
tomaka Nov 21, 2023
755a28a
No longer have this weird `response_outcome`variable
tomaka Nov 21, 2023
ac4f179
Inline `inject_network_event`
tomaka Nov 21, 2023
48220ea
Integrate the network state update within the WakeUpReason
tomaka Nov 21, 2023
63d0276
Inline the request results match block
tomaka Nov 21, 2023
a07106c
Inline `start_next_request`
tomaka Nov 21, 2023
0a31652
Get the desired request ahead of time to fix compilation
tomaka Nov 21, 2023
329a280
Add TODO
tomaka Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/src/sync/all.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1878,13 +1878,15 @@ pub enum DesiredRequest {

impl DesiredRequest {
/// Caps the number of blocks to request to `max`.
// TODO: consider removing due to the many types of requests
pub fn num_blocks_clamp(&mut self, max: NonZeroU64) {
if let DesiredRequest::BlocksRequest { num_blocks, .. } = self {
*num_blocks = NonZeroU64::new(cmp::min(num_blocks.get(), max.get())).unwrap();
}
}

/// Caps the number of blocks to request to `max`.
// TODO: consider removing due to the many types of requests
pub fn with_num_blocks_clamp(mut self, max: NonZeroU64) -> Self {
self.num_blocks_clamp(max);
self
Expand Down
Loading
Loading