Track number of connections per address in peering strategy #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the situation where the discovery system discovers the same address for two different peers (Alice and Bob), the code will try to connect to both.
Inevitably, one of them will redirect to the wrong peer, for example connecting to Alice will actually connect to Bob.
Later, when we disconnect a second time from Bob, a state mismatch is found and a panic happens.
This PR does things properly and tracks the number of connections per peer.
We also handle weird situations properly, such as connecting to the same address multiple times leading to multiple different peer ids, by removing the
remove_addressfunction entirely.