Ban peers when a request fails #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
commented
Dec 19, 2023
| @@ -1223,12 +1274,24 @@ impl<TPlat: PlatformRef> Task<TPlat> { | |||
| HashDisplay(&verified_hash), | |||
| error | |||
| ); | |||
|
|
|||
| // TODO: ban peers that have announced the block | |||
There was a problem hiding this comment.
Last thing to do before merging
There was a problem hiding this comment.
I've changed my mind about the fact that this is needed before merging.
We obviously need the help of the sync state machine here, but its guarantees in corner cases (such as knowing which sources know about a bad block) are not very well defined. The sync state machine needs a general clean-up, which is currently blocked on #1409.
I don't think that banning peers that advertise bad blocks is critical, and so it's fine to leave it as a todo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #1442
Work in progress. While I wouldn't mind merging as is (except for the CHANGELOG), the unused function warning makes the compilation fail.