Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the allocator to allocate the input parameters of the VM #188

Merged
merged 13 commits into from
Feb 20, 2023

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Feb 15, 2023

Fix #132

@github-actions
Copy link

github-actions bot commented Feb 15, 2023

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
       +1432 ┊ smoldot::executor::vm::VirtualMachine::run::h8577424b437054ac
       -1432 ┊ smoldot::executor::vm::VirtualMachine::run::hc7303fd56322c435
       -1290 ┊ smoldot::executor::vm::VirtualMachinePrototype::start::hef06d3654c92fbc9
       +1065 ┊ smoldot::executor::vm::Prepare::start::h7344c285b56283ae
        +668 ┊ smoldot::executor::allocator::FreeingBumpHeapAllocator::allocate::hf009a270523827a4
        -430 ┊ smoldot::executor::host::Inner::alloc::he01d2d9c015a2e06
        -396 ┊ smoldot::executor::host::HostVmPrototype::new::h7db9ad5838b3b522
        +396 ┊ smoldot::executor::host::HostVmPrototype::new::h821a347d75ec7d4d
        -376 ┊ smoldot::executor::vm::VirtualMachine::into_prototype::h3db971345144df3e
        +376 ┊ smoldot::executor::vm::VirtualMachine::into_prototype::ha48d213468b1a740
        -353 ┊ <&T as core::fmt::Display>::fmt::hee835bdff424e241
        +351 ┊ <smoldot::executor::vm::Signature as core::convert::TryFrom<&wasmi::func::func_type::FuncType>>::try_from::h91fd13465114cc4b
        -351 ┊ <smoldot::executor::vm::Signature as core::convert::TryFrom<&wasmi::func::func_type::FuncType>>::try_from::hce7ab056328c2e0c
        -341 ┊ <smoldot::executor::vm::NewErr as core::fmt::Debug>::fmt::h89ac9e838daeafbf
        +341 ┊ <smoldot::executor::vm::NewErr as core::fmt::Debug>::fmt::h8c86ccff83ace7d2
        +329 ┊ <&T as core::fmt::Display>::fmt::hdb10927c41e52b50
        +317 ┊ <smoldot::executor::host::MemAccess as smoldot::executor::allocator::Memory>::read_le_u64::hdefef17d1dcef2f0
        +198 ┊ smoldot::executor::host::HostVmPrototype::run_vectored::hffa60afe73b19551
        +197 ┊ smoldot::executor::host::HostVmPrototype::run_vectored::h68bfe9fdc81a0f87
        +197 ┊ smoldot::executor::host::HostVmPrototype::run_vectored::hb42ba4e0a08da488
       +1740 ┊ ... and 71 more.
       +3324 ┊ Σ [91 Total Rows]

@tomaka tomaka mentioned this pull request Feb 15, 2023
@tomaka tomaka added this pull request to the merge queue Feb 20, 2023
Merged via the queue into smol-dot:main with commit 6b12d7f Feb 20, 2023
@tomaka tomaka deleted the fix-132 branch February 20, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the allocator to allocate the input data in the VM
1 participant