Fix #2035 #2037
Merged
Fix #2035 #2037
+2,401
−2,434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
commented
Nov 18, 2024
| return Err(IncompleteProofError()); | ||
| } | ||
|
|
||
| for c in 0..key_before_nibble { | ||
| for c in 0..child_num { |
There was a problem hiding this comment.
Note that this could be key_before_nibble as well, and in fact it would be slightly faster to keep key_before_nibble (we know that the range between key_before_nibble and child_num is always empty), but using child_num makes this code way less confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2035
This took me some time, as I had to get a proper understanding of the code first, but I'm 99.9% confident that what my PR changes is just a stupid mistake as I used the wrong variable in this edge case.
Work time: 1h