Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust naming of allHead notifications #227

Merged
merged 3 commits into from
Feb 24, 2023

Conversation

skunert
Copy link
Contributor

@skunert skunert commented Feb 24, 2023

When a client was subscribing to chain_subscribeAllHeads, notifications received included chain_newHead in the method field.
After this PR the notification method will say chain_allHead like in substrate.

@skunert skunert requested a review from tomaka as a code owner February 24, 2023 13:16
@tomaka
Copy link
Contributor

tomaka commented Feb 24, 2023

Thanks!

I've taken the liberty to push a commit with a CHANGELOG entry.

@github-actions
Copy link

github-actions bot commented Feb 24, 2023

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
       -6081 ┊ futures_util::abortable::Abortable<T>::try_poll::h877c3b09f3fdc96f
       +6081 ┊ futures_util::abortable::Abortable<T>::try_poll::h96e97dadbcd88406
       +2293 ┊ smoldot::json_rpc::methods::ServerToClient::params_to_json_object::h3231c257c2e4602a
       -2102 ┊ smoldot::json_rpc::methods::ServerToClient::params_to_json_object::h8be81ea8feb254b4
       -1848 ┊ futures_util::abortable::Abortable<T>::try_poll::h581e9258ae7fb524
       +1848 ┊ futures_util::abortable::Abortable<T>::try_poll::hdd070876890841b7
        -857 ┊ futures_util::abortable::Abortable<T>::try_poll::h968e38209b218347
        +857 ┊ futures_util::abortable::Abortable<T>::try_poll::h99afee80048ea96b
        -857 ┊ futures_util::abortable::Abortable<T>::try_poll::hb15be826847eaa0d
        +857 ┊ futures_util::abortable::Abortable<T>::try_poll::hf9f91d1eb83b83ae
        -712 ┊ core::ptr::drop_in_place<smoldot_light::json_rpc_service::chain_head::<impl smoldot_light::json_rpc_service::Background<smoldot_light_wasm::platform::Platform>>::chain_head_follow::{{closure}}::{{closure}}>::h13a42c003649a095
        +712 ┊ core::ptr::drop_in_place<smoldot_light::json_rpc_service::chain_head::<impl smoldot_light::json_rpc_service::Background<smoldot_light_wasm::platform::Platform>>::chain_head_follow::{{closure}}::{{closure}}>::he044ef626ba8953b
        +674 ┊ core::ptr::drop_in_place<smoldot::json_rpc::methods::ServerToClient>::h585eaf929489bc7c
        -646 ┊ core::ptr::drop_in_place<smoldot::json_rpc::methods::ServerToClient>::h4874792e4ae96ff2
        -499 ┊ futures_util::abortable::Abortable<T>::try_poll::h362d7a5ccc17af72
        +499 ┊ futures_util::abortable::Abortable<T>::try_poll::hc63d1ffe0337f9b2
        -331 ┊ core::ptr::drop_in_place<smoldot_light::json_rpc_service::state_chain::<impl smoldot_light::json_rpc_service::Background<smoldot_light_wasm::platform::Platform>>::chain_subscribe_all_heads::{{closure}}::{{closure}}>::h5df58d56ba6d5b38
        +331 ┊ core::ptr::drop_in_place<smoldot_light::json_rpc_service::state_chain::<impl smoldot_light::json_rpc_service::Background<smoldot_light_wasm::platform::Platform>>::chain_subscribe_all_heads::{{closure}}::{{closure}}>::hd0c5bc96e986c5d7
        +325 ┊ core::ptr::drop_in_place<smoldot_light::json_rpc_service::chain_head::<impl smoldot_light::json_rpc_service::Background<smoldot_light_wasm::platform::Platform>>::chain_head_follow::{{closure}}>::hd3d9f8d9d3388bc3
        -325 ┊ core::ptr::drop_in_place<smoldot_light::json_rpc_service::chain_head::<impl smoldot_light::json_rpc_service::Background<smoldot_light_wasm::platform::Platform>>::chain_head_follow::{{closure}}>::hd6cd2f9c88cca114
         +16 ┊ ... and 70 more.
        +235 ┊ Σ [90 Total Rows]

@tomaka tomaka added this pull request to the merge queue Feb 24, 2023
Merged via the queue into smol-dot:main with commit 890f31a Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants