Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return an error if a request exceeds the maximum allowed size, instead of panicking #318

Merged
merged 4 commits into from
Mar 20, 2023

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Mar 20, 2023

Fix #317

@github-actions
Copy link

github-actions bot commented Mar 20, 2023

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
       +3597 ┊ smoldot_light::sync_service::SyncService<TPlat>::storage_query::{{closure}}::h15082c3c86cac6eb
       -3550 ┊ smoldot_light::sync_service::SyncService<TPlat>::storage_query::{{closure}}::h7314eba305ab632a
       +3362 ┊ smoldot_light::sync_service::SyncService<TPlat>::storage_query::{{closure}}::h311ea8c68b87434f
       -3291 ┊ smoldot_light::sync_service::SyncService<TPlat>::storage_query::{{closure}}::h1ca8ecd2286d85ea
       +1850 ┊ futures_util::abortable::Abortable<T>::try_poll::hf6a1a53196ac783b
       -1823 ┊ futures_util::abortable::Abortable<T>::try_poll::h919e7133a16178ce
        -407 ┊ smoldot::libp2p::connection::established::single_stream::SingleStream<TNow,TRqUd,TNotifUd>::add_request::h2cd1d3ed97c5c74a
        +403 ┊ smoldot::libp2p::collection::Network<TConn,TNow>::start_request::h349f9312fee43167
        +380 ┊ smoldot::libp2p::connection::established::single_stream::SingleStream<TNow,TRqUd,TNotifUd>::add_request::h9918907f4bea199c
        -367 ┊ smoldot::libp2p::connection::established::multi_stream::MultiStream<TNow,TSubId,TRqUd,TNotifUd>::add_request::hcc890fbc5f12bfea
        +340 ┊ smoldot::libp2p::connection::established::multi_stream::MultiStream<TNow,TSubId,TRqUd,TNotifUd>::add_request::h10cb88fc88fd077d
        -306 ┊ smoldot::libp2p::collection::Network<TConn,TNow>::start_request::hb54a6cb4a8e25e6c
        +305 ┊ <futures_util::future::select::Select<A,B> as core::future::future::Future>::poll::h2193adc856fd22b0
        -305 ┊ <futures_util::future::select::Select<A,B> as core::future::future::Future>::poll::h5195cced65f580d6
        +297 ┊ <alloc::vec::Vec<T,A> as core::clone::Clone>::clone::hffbc9eb53b25f2d8
        +278 ┊ smoldot::network::service::requests_responses::<impl smoldot::network::service::ChainNetwork<TNow>>::start_call_proof_request::h578cfca3731af80e
        +278 ┊ smoldot::network::service::requests_responses::<impl smoldot::network::service::ChainNetwork<TNow>>::start_call_proof_request::h7afed870dd3c6be2
        +278 ┊ smoldot::network::service::requests_responses::<impl smoldot::network::service::ChainNetwork<TNow>>::start_call_proof_request::hdb61daa74da9de20
        +278 ┊ smoldot::network::service::requests_responses::<impl smoldot::network::service::ChainNetwork<TNow>>::start_storage_proof_request::h63e0d31205be9449
        +278 ┊ smoldot::network::service::requests_responses::<impl smoldot::network::service::ChainNetwork<TNow>>::start_storage_proof_request::hdc2852f99b727a19
        -286 ┊ ... and 321 more.
       +1690 ┊ Σ [341 Total Rows]

@tomaka tomaka added this pull request to the merge queue Mar 20, 2023
@tomaka tomaka merged commit 124f57e into smol-dot:main Mar 20, 2023
@tomaka tomaka deleted the max-rq-size branch March 20, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smoldot has panicked while executing task connections
1 participant