Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable post-MVP Wasm features #386

Merged
merged 5 commits into from
Apr 3, 2023
Merged

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Apr 3, 2023

Close #217

It's unclear to me whether sign-ext and Non-trapping float-to-int conversions should be disabled as well. See paritytech/substrate#10707 (comment).

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼──────────────────────────────────────────────────────────────────────────────────────
        -183 ┊ <wasmi::engine::Engine as core::default::Default>::default::h3c493386f3d4acb5
        +138 ┊ smoldot::executor::vm::interpreter::InterpreterPrototype::new::h657255d0b93b4b88
        +136 ┊ <wasmi::engine::config::Config as core::default::Default>::default::h51acb3769bb26f13
         +13 ┊ wasmi::engine::config::Config::wasm_bulk_memory::h298fdff5a68bd003
         +13 ┊ wasmi::engine::config::Config::wasm_extended_const::hb703c453ded2d9f2
         +13 ┊ wasmi::engine::config::Config::wasm_multi_value::h7dd41a6ece67399f
         +13 ┊ wasmi::engine::config::Config::wasm_mutable_global::h3f380dd6f8ad5446
         +13 ┊ wasmi::engine::config::Config::wasm_reference_types::h50300a32d2158107
         +13 ┊ wasmi::engine::config::Config::wasm_saturating_float_to_int::he9f95d8a168a4fe5
         +13 ┊ wasmi::engine::config::Config::wasm_sign_extension::he0d7e712a68c2281
         +13 ┊ wasmi::engine::config::Config::wasm_tail_call::hd204389c1737a7e1
          +3 ┊ elem[0]
        +805 ┊ Σ [12 Total Rows]

@tomaka tomaka enabled auto-merge April 3, 2023 15:50
@tomaka tomaka added this pull request to the merge queue Apr 3, 2023
Merged via the queue into smol-dot:main with commit 7581f75 Apr 3, 2023
@tomaka tomaka deleted the disable-wasm-features branch April 3, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deny Wasm features that are experimental
1 participant