Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request justifications of blocks on epoch change #441

Merged
merged 4 commits into from
Apr 19, 2023
Merged

Request justifications of blocks on epoch change #441

merged 4 commits into from
Apr 19, 2023

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Apr 19, 2023

Should fix #239

This PR does the following:

  • We now track the finalized block of all of our peers based on the GrandPa neighbor message that they send.
  • Send out justification requests when a peer has a finalized block superior or equal to a local "finality checkpoint". A "finality checkpoint" is a block that needs to be finalized before any other block on top can be finalized as well, which represents epoch changes.

@tomaka tomaka added this pull request to the merge queue Apr 19, 2023
@tomaka tomaka mentioned this pull request Apr 19, 2023
Closed
Merged via the queue into smol-dot:main with commit 214bccf Apr 19, 2023
@tomaka tomaka deleted the track-finalized-num branch April 19, 2023 08:49
@vikinatora vikinatora mentioned this pull request Apr 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Light-node stops reporting finalized headers for certain chain-specs
1 participant
@tomaka