Fix panic in case of invalid checkpoint in chain spec #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, This is the spec that I was using: Before this patchthread 'main' panicked at 'attempt to subtract with overflow', /Users/lexnv/.cargo/git/checkouts/smoldot-2dcbf637e11a77d4/43b3306/lib/src/chain_spec.rs:445:37
note: run with `RUST_BACKTRACE=1` environment variable to display a backtraceAfter this patchError: LightClient(AddChainError("Invalid checkpoint in chain specification: EmptyBabeEpochsList")) |
lexnv
previously approved these changes
May 25, 2023
Ah, thanks for testing! That's very weird and annoying, as to me this indicates an invalid checkpoint. |
|
The core of the problem is that I have no idea what constitutes a valid checkpoint, cc paritytech/polkadot-sdk#60 I suppose that if the list of epochs is empty, then we should simply ignore the checkpoint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix paritytech/substrate#598
cc @lexnv
Would be great to have a test case, but generating one myself would legitimately take me several hours.
@lexnv If you could upload somewhere the chain spec JSON that triggers a panic so that I include it as a regression test in this PR, it would be great 🙏 If not possible or too annoying, then it's not a big deal.