Fix and clarify the JSON-RPC queue full behaviour #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #804
This fixes a change in behavior that was accidentally introduced in #793, and clarifies everywhere that "queue full" means "maximum number of pending requests reached".
cc @lexnv and maybe @skunert
This PR changes nothing compared to the previously released version (it fixes a bug in a PR made yesterday), but clarifies that the "queue full" error potentially returned by
json_rpc_requestsimply means thatConfig::max_pending_requestshas been reached.For your specific use case, passing
max_pending_requests: u32::max_value()(and same for the max subscriptions option) is the most appropriate.