New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix network_service discarding events #967

Merged

tomaka merged 2 commits into smol-dot:main from tomaka:fix-956

Jul 26, 2023

Contributor

tomaka commented Jul 26, 2023

Fix #956

Right now, if can_generate_events is false, we call next_event anyway but discard the event. This is obviously the wrong thing to do.

tomaka added 2 commits

July 26, 2023 15:53


          Fix network_service discarding events

aea2023


          PR link

ff59f7b

tomaka added this pull request to the merge queue

Merged via the queue into smol-dot:main with commit 1702f17

20 checks passed

tomaka deleted the fix-956 branch

July 26, 2023 14:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet