alg: Push tasks directly to the local runner, take 2 #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeenix
approved these changes
Jul 2, 2023
notgull
force-pushed
the
notgull/cached-task-2
branch
from
537a508 to
e436d2b
Compare
Merged
notgull
added a commit
that referenced
this pull request
Aug 20, 2023
This commit makes sure that the run() and tick() functions produce futures that are Send and Sync, to prevent a regression introduced in Signed-off-by: John Nunley <dev@notgull.net> #37. Tests are also added to prevent this regression in the future.
notgull
added a commit
that referenced
this pull request
Aug 20, 2023
This commit makes sure that the run() and tick() functions produce futures that are Send and Sync, to prevent a regression introduced in PR #37. Tests are also added to prevent this regression in the future. Signed-off-by: John Nunley <dev@notgull.net>
notgull
added a commit
that referenced
this pull request
Aug 21, 2023
This commit makes sure that the run() and tick() functions produce futures that are Send and Sync, to prevent a regression introduced in PR #37. Tests are also added to prevent this regression in the future. Signed-off-by: John Nunley <dev@notgull.net>
notgull
added a commit
that referenced
this pull request
Oct 17, 2023
This was added in #37 as an optimization, but has since lead to many bugs. See the issues #53, #57 and #60 for more information. I do not have the bandwidth to address all of these bugs, so I'm taking the path of least resistance by just removing the problematic code. CLoses #53, #57 and #60 Signed-off-by: John Nunley <dev@notgull.net>
notgull
added a commit
that referenced
this pull request
Oct 17, 2023
This was added in #37 as an optimization, but has since lead to many bugs. See the issues #53, #57 and #60 for more information. I do not have the bandwidth to address all of these bugs, so I'm taking the path of least resistance by just removing the problematic code. CLoses #53, #57 and #60 Signed-off-by: John Nunley <dev@notgull.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #36 by pushing tasks directly to the local runner. A thread-local variable is used to cache a reference to the current
Runnerwhich is then used byschedule()to push tasks directly to the local queue.This has led to significant improvements in some of our benchmarks! Around 10% in the main use cases, and 77% in the yield now case.