Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize networking on Windows #183

Merged
merged 3 commits into from
Jan 27, 2024
Merged

Initialize networking on Windows #183

merged 3 commits into from
Jan 27, 2024

Conversation

notgull
Copy link
Member

@notgull notgull commented Jan 26, 2024 

This commit adds a setup_networking function. On most platforms it does
nothing. However, on Windows it calls `wsa_startup`. This ensures that
all networking is set up before anything else is called.

Closes #182

@notgull
Initialize networking before running connect()
fcc4435 
This commit adds a setup_networking function. On most platforms it does
nothing. However, on Windows it calls `wsa_startup`. This ensures that
all networking is set up before anything else is called.

Closes #182

Signed-off-by: John Nunley <dev@notgull.net>
@notgull
Set up a test
298568e 
Signed-off-by: John Nunley <dev@notgull.net>
@notgull notgull requested a review from fogti January 26, 2024 04:11
@notgull
Ignore nslookup failure
8741554 
Signed-off-by: John Nunley <dev@notgull.net>
@notgull notgull merged commit adf46bb into master Jan 27, 2024
18 of 21 checks passed
@notgull notgull deleted the notgull/windows branch January 27, 2024 17:42
@notgull notgull mentioned this pull request Jan 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fogti fogti Awaiting requested review from fogti

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@notgull