Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the pre-exec extension function #54

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Conversation

notgull
Copy link
Member

@notgull notgull commented Sep 28, 2023

The purpose for removing this function is twofold:

  • It is the only unsafe code in this crate that can't be realistically replaced with safe code.
  • It is a footgun anyways, and can be done anyways with Into::into() if users really want it.

This is a breaking change.

@notgull
Copy link
Member Author

notgull commented Sep 29, 2023

I can't replicate the test failures on my machine, even with:

for i in $(seq 0 1000); do
    cargo test
done

Copy link
Collaborator

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

notgull added a commit that referenced this pull request Oct 6, 2023
Extracted from #54, should fix #55

Signed-off-by: John Nunley <dev@notgull.net>
@notgull
Copy link
Member Author

notgull commented Oct 6, 2023

Thanks for the review! I'd rather merge #56 before we have a breaking change blocked on master.

notgull added a commit that referenced this pull request Oct 6, 2023
Extracted from #54, should fix #55

Signed-off-by: John Nunley <dev@notgull.net>
The purpose for removing this function is twofold:

- It is the only unsafe code in this crate that can't be realistically
  replaced with safe code.
- It is a footgun anyways, and can be done anyways with Into::into() if
   users really want it.

This is a breaking change.

Signed-off-by: John Nunley <dev@notgull.net>
@notgull notgull force-pushed the notgull/no-pre-exec branch from f2bfaab to 558bf2a Compare October 8, 2023 03:52
@notgull notgull merged commit b29af2b into master Oct 8, 2023
14 checks passed
@notgull notgull deleted the notgull/no-pre-exec branch October 8, 2023 04:06
@notgull notgull mentioned this pull request Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants