Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AtomicUsize instead of AtomicU64 to count zombies for 32-bit compatibility #75

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Use AtomicUsize instead of AtomicU64 to count zombies for 32-bit compatibility #75

merged 1 commit into from
Apr 12, 2024

Conversation

kennytm
Copy link
Contributor

@kennytm kennytm commented Apr 12, 2024

Fix #74.

@kennytm kennytm mentioned this pull request Apr 12, 2024
Closed
@kennytm kennytm changed the title Use AtomicUsize instead of U64 to count zombies for 32-bit compatibility Use AtomicUsize instead of AtomicU64 to count zombies for 32-bit compatibility Apr 12, 2024
notgull
notgull approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@notgull notgull merged commit 06fb10a into smol-rs:master Apr 12, 2024
14 checks passed
@kennytm kennytm deleted the fix-74 branch April 12, 2024 00:03
@notgull notgull mentioned this pull request Apr 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notgull notgull notgull approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reduce the Reaper::zombies from AtomicU64 to AtomicUsize or less
2 participants
@kennytm @notgull