fix: use signal backend on android #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rustix does not expose pidfd functions for android, so this commit changes so that the signal backend is used on android. The pidfd functions were introduced in Linux kernel 5.1, and epoll integration were introduced in 5.3. Android version 13, is the first version where all released version of the Android common kernel is based on Linux kernel 5.4 or higher. <https://source.android.com/docs/core/architecture/kernel/android-common> Resolves Issue smol-rs#79
notgull
approved these changes
May 26, 2024
yes, i'll add a test |
|
I am working on tests, but currently all tests pass except (all in tests/std.rs):
All 3 tests fails because they can't find I will give the qemu another look later. |
|
A full test is overkill and can be done in another PR. For now just make sure it builds. |
Closed
I think we can support this case by copying more things here. |
kod-kristoff
force-pushed
the
use-signal-reaper-on-android
branch
from
5668511 to
2ed6dae
Compare
I have change so that the crate only is built for android |
Co-authored-by: John Nunley <jtnunley01@gmail.com>
This was referenced Jun 1, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rustix does not expose pidfd functions for android, so this
commit changes so that the signal backend is used on android.
The pidfd functions were introduced in Linux kernel 5.1, and
epoll integration were introduced in 5.3.
Android version 13, is the first version where all released
version of the Android common kernel is based on Linux kernel
5.4 or higher.
https://source.android.com/docs/core/architecture/kernel/android-common
Resolves Issue #79