feat: Add no_std mode #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fogti
requested changes
Feb 17, 2023
src/lib.rs
Outdated
| @@ -598,6 +611,7 @@ impl Rng { | |||
| } | |||
|
|
|||
| /// Run an operation with the current thread-local generator. | |||
| #[cfg(feature = "std")] | |||
| #[inline] | |||
| fn with_rng<R>(f: impl FnOnce(&mut Rng) -> R) -> R { | |||
There was a problem hiding this comment.
wouldn't it make more sense to put this into $crate scope and get rid of the dozens of functions which just wrap with_rng?
anyways, it might be a good idea to move all the thread-local+Cell dependent stuff into a separate module, and include it here with
#[cfg(feature = "std")]
mod glrng;
#[cfg(feature = "std")]
pub use glrng::*;that would imo be much cleaner.
There was a problem hiding this comment.
I'm hesitant to expose (try_)with_rng, since I feel like the API is much more idiomatic without giving direct access to the thread-local RNG. Anyways, I moved the thread-local things into a global_rng module.
notgull
force-pushed
the
notgull/no_std
branch
from
e6fa33f
to
6455b1a
Compare
fogti
approved these changes
Feb 19, 2023
Merged
notgull
added a commit
that referenced
this pull request
Jun 9, 2023
- **Breaking:** Remove interior mutability from `Rng`. (#47) - Add a `fork()` method. (#49) - Add a `no_std` mode. (#50) - Add an iterator selection function. (#51) - Add a `choose_multiple()` function for sampling several elements from an iterator. (#55) - Use the `getrandom` crate for seeding on WebAssembly targets if the `js` feature is enabled. (#60)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a feature named
std. When disabled, the thread-local generator andRng::new()are disabled. This allowsfastrandto be used inno_stdenvironments.