This repository has been archived by the owner on May 1, 2021. It is now read-only.
Add VSOCK socket support #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently limited to Unix, but could be extended to Windows once the AF_VSOCK API is bound. Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
taiki-e
reviewed
Jan 11, 2021
There was a problem hiding this comment.
Since vsock-rs's major version is less than 1, it is basically unacceptable to have their types as public API. Also, I'm not clear about the maintenance status of that project.
So, I would recommend doing this as a separate crate for now.
I'm going to close this, but thanks @elmarco for the PR!
@taiki-e ok, can we make the connect() method public then? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gated as an optional feature, using vsock-rs.