Implement loom version of parking #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fogti
reviewed
Oct 3, 2022
fogti
reviewed
Oct 3, 2022
|
The CI isn't running for some reason, let me try closing and reopening. |
|
don't worry CI auto-disabled due to infrequent usage |
|
Should work after rebasing this branch against |
fogti
reviewed
Oct 3, 2022
src/lib.rs
Outdated
| use std::cell::Cell; | ||
| use std::fmt; | ||
| use std::marker::PhantomData; | ||
| use std::sync::atomic::AtomicUsize; | ||
| use std::sync::atomic::Ordering::SeqCst; | ||
| use std::sync::{Arc, Condvar, Mutex}; | ||
| use std::time::{Duration, Instant}; |
There was a problem hiding this comment.
Are these used when #[cfg(loom)] is active?
There was a problem hiding this comment.
Yes. I import either the std::sync or loom::sync module based on the configuration, and then I import synchronization primitives straight from the resulting sync module.
There was a problem hiding this comment.
nah, I'm talking about std::time::* stuff...
There was a problem hiding this comment.
Duration is used but Instant is not. This should now be fixed.
|
@smol-rs/admins Any blockers to this being merged? |
taiki-e
approved these changes
Oct 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In smol-rs/event-listener#30, I implemented my own version of
parkingusing Loom primitives. @zseri asked me to upstream it to this repository. This PR adds a new "loom" feature that, when the Rust--cfg loomflag is enabled, reimplementsparkingusing Loom primitives.Since
loomdoesn't support timeouts there's not much that I can really do in terms of testing, so I just added a simple smoke test.