Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't make MainExecutor private/hidden #10

Closed
wants to merge 2 commits into from

Conversation

brandonros
Copy link

@brandonros brandonros commented Oct 20, 2024

I get that this is awkward and not a real solution (more of a proposal to discuss ideas, if wanted)

As somebody "new" looking to learn a bit more about smol and the async- package ecosystem, I found it awkward and not intuitive/friendly that MainExecutor isn't included in smol or async-executor and instead hidden away here.

What is an improvement that could be made either in this crate or smol / async-executor so that there is a more clear "default" implementation more robust than a single-threaded block_on?

@fogti
Copy link
Member

fogti commented Oct 20, 2024

putting MainExecutor into async-executor (perhaps behind an additional, convenience feature) would probably a better idea than making it public here.

@brandonros
Copy link
Author

moved to smol-rs/async-executor#134 if you can help me recommend what else to do/name things

thank you!

@brandonros brandonros closed this Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants