Fix the error of specific length IP packets not being fragmented #1008
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an obvious mistake at
src/iface/interface/mod.rs:1204
:total_ip_len
represents the length of the IP packet, whileself.caps.max_transmission_unit
is the max length of link-layer packets. The correct comparison should be with self.caps.ip_mtu().When using Medium Ethernet, since
self.caps.max_transmission_unit
is 14 octets larger thanself.caps.ip_mtu()
, IP packets with length of 1501~1514 octets should be fragmented, but mistakenly entered the non-fragment branch.Additionally, I added a test case sending IPv4 packets of different lengths, which can trigger this error.