Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NDISC: option parsing is the same for all NDISC types #878

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

thvdveld
Copy link
Contributor

This removes the foreach_option function and instead tries to parse all options. Since the way options are parsed is the same for all messages, this is a bit more efficient in terms of code size.

Running cargo bloat --release --example server --filter smoltcp:
On main: 216.3KiB
On this branch: 213.9KiB

Running cargo bloat --release --example sixlowpan --filter smoltcp:
On main: 213.9KiB
On this branch: 211.4KiB

This removes the foreach_option function and instead tries to parse all
options. Since the way options are parsed is the same for all messages,
this is a bit more efficient in terms of code size.
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (8a86a5a) 79.74% compared to head (2d862b2) 79.76%.

Files Patch % Lines
src/wire/ndisc.rs 68.08% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #878      +/-   ##
==========================================
+ Coverage   79.74%   79.76%   +0.01%     
==========================================
  Files          78       78              
  Lines       28131    28092      -39     
==========================================
- Hits        22433    22407      -26     
+ Misses       5698     5685      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thvdveld thvdveld added this pull request to the merge queue Dec 19, 2023
Merged via the queue into smoltcp-rs:main with commit 8b59d57 Dec 19, 2023
14 checks passed
@thvdveld thvdveld deleted the modify-ndisc-parsing branch December 19, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant