Ipv6RoutingHeader::clear_reserved: fix offsets for Type 2 routing headers. #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #882 +/- ##
=======================================
Coverage 79.77% 79.77%
=======================================
Files 78 78
Lines 28133 28133
=======================================
Hits 22443 22443
Misses 5690 5690 ☔ View full report in Codecov by Sentry. |
Using 0xff filled buffers as test vectors to ensure that the reserved fields are cleared to 0.
|
Thank you! I updated the emit test to make sure that this is not missed when changes are made to the logic. |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this off-by-2, bytes 6 & 7 are part of the
Home Addressfield not the Reserved portion.