Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multicast: use a single map for both ipv4 and ipv6. #976

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

Dirbaio
Copy link
Member

@Dirbaio Dirbaio commented Aug 19, 2024

Advantages:

  • Deduplicates logic a bit
  • The "max multicast group count" compile-time config now actually makes sense. Before the actual max was 2n, but only reachable with N ipv4 and N ipv6.

@Dirbaio Dirbaio force-pushed the multicast-single-map branch from 912c66c to 4990fb9 Compare August 19, 2024 22:04
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 8 lines in your changes missing coverage. Please review.

Project coverage is 79.27%. Comparing base (dc08e0b) to head (4990fb9).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/iface/interface/igmp.rs 78.94% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #976   +/-   ##
=======================================
  Coverage   79.27%   79.27%           
=======================================
  Files          81       81           
  Lines       26918    26926    +8     
=======================================
+ Hits        21339    21346    +7     
- Misses       5579     5580    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thvdveld thvdveld added this pull request to the merge queue Aug 29, 2024
Merged via the queue into main with commit de2dfe1 Aug 29, 2024
11 checks passed
@thvdveld thvdveld deleted the multicast-single-map branch August 29, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants