feat: stop sending metrics when CLI command is executed on CI/CD pipeline #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoya
reviewed
Jan 29, 2024
| @@ -80,7 +80,8 @@ export default abstract class extends Command { | |||
|
|
|||
| recorderFromEnv(prefix: string): Recorder { | |||
| let sink: Sink = new DiscardSink(); | |||
| if (process.env.ASYNCAPI_METRICS !== 'false') { | |||
|
|
|||
| if (process.env.ASYNCAPI_METRICS !== 'false' && process.env.CI !== 'true') { | |||
There was a problem hiding this comment.
Shouldn't be this an OR rather than an AND?
Suggested change
| if (process.env.ASYNCAPI_METRICS !== 'false' && process.env.CI !== 'true') { | |
| if (process.env.ASYNCAPI_METRICS !== 'false' || process.env.CI !== 'true') { |
There was a problem hiding this comment.
Not sure about it 🤔
What if ASYNCAPI_METRICS = 'true' and CI = 'true'? In that situation we would be sending metrics when applying the OR condition. So if that scenario is possible, shouldn't we apply the AND condition instead?
smoya
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stop sending metrics when
process.env.NODE_ENV === 'CI', which means that a CLI command is executed on CI/CD pipeline.