-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: solve optimize
command issue when sending data to New Relic
#13
fix: solve optimize
command issue when sending data to New Relic
#13
Conversation
The |
The metric cc @smoya |
The value in In order to allow filtering/querying/grouping/etc by those attributes, you will need to send them separated in different attributes. For example: {
"optimization_remove-components": true,
"optimization_reuse-components": true,
"optimization_move-to-components": true,
"success": true,
"asyncapi_blablabla": "etc etc etc"
} |
Metadata attributes already adapted to NR requirements 👍 |
Working on the test failing: |
Cognitive complexity issue solved and failing test fixed with this commit: 737f3ee |
@smoya |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactor applied and --optimization
flag working correctly now. Ready to merge 🚀
Description
Solving issue from
optimize
command when sending data to New Relic servers.Basically,
action.finished
metric is not sent to NR servers probably because of the format accepted by New Relic API.