feat: send metrics to NR only when installed as NPM binary #2
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
smoya
force-pushed
the
feat/newRelicOnProd
branch
from
1994f4d to
981ed18
Compare
smoya
force-pushed
the
feat/adoptionMetrics
branch
from
c9027b5 to
e9e79f6
Compare
smoya
force-pushed
the
feat/newRelicOnProd
branch
from
981ed18 to
82960a1
Compare
| @@ -82,8 +82,7 @@ export default class Convert extends Command { | |||
| metadata['success'] = true; | |||
| metadata['from_version'] = document.version(); | |||
| metadata['to_version'] = flags['target-version']; | |||
| console.log(metadata); | |||
There was a problem hiding this comment.
Tests were failing due to this console.log printing things to stdout. Some of our integration tests are based on the stdout made by the cli and this was polluting it.
|
I'm gonna merge this PR. CI fails because of linter complaining about complexity on some methods. This is due to a lot of boilerplate we are pasting into the commands for sending the metrics. We should definitely simplify that code that is basically repeated all around. See https://github.com/smoya/cli/actions/runs/6968132068/job/18961404969?pr=2 cc @peter-rr |
Description
This PR enables the New Relic sink only when the CLI runs as binary installed by NPM (
npm install -g @asyncapi/cli). Otherwise, metrics are just printed to stdout (Through the StdOut sink).In order to do that, I created a new file in
bindirectory calledbin/run_binwhich is the one the binary will call. It is not specified in thebinsection of thepackage.json.This PR also updates the
@smoya/asyncapi-adoption-metricsdependency to latest and adapts the code to latest renamings in such library.cc @peter-rr