feat: add new metric recording for action invocation #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoya
force-pushed
the
feat/adoptionMetrics
branch
from
c9027b5 to
e9e79f6
Compare
smoya
requested changes
Nov 23, 2023
| @@ -112,6 +112,16 @@ export default class Template extends Command { | |||
| parser = new Parser(); | |||
|
|
|||
| async run() { | |||
| try { | |||
| // Metrics recording when command is invoked | |||
| await this.recorder.recordActionInvoked('fromTemplate'); | |||
There was a problem hiding this comment.
I would aa a prefix to the action including then the generate word. Like generate_from_template or similar
There was a problem hiding this comment.
Yeah, makes sense 👍
…-rr/cli into feat/new-metric-for-action-invoked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new metric recording when a command is invoked. The metrics are sent correctly to both
NewRelicsink andStdOutsink.This is just a first iteration. Working now on this metric implementation by making use of OCLIF hooks.