Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package is missing dependencies in pyproject.toml #19

Closed
w8jcik opened this issue Feb 18, 2024 · 5 comments
Closed

Package is missing dependencies in pyproject.toml #19

w8jcik opened this issue Feb 18, 2024 · 5 comments

Comments

@w8jcik
Copy link

w8jcik commented Feb 18, 2024

  • snakemake-interface-common
  • snakemake-interface-storage-plugins
@w8jcik w8jcik changed the title Package is missing dependencies in pyproject.toml. Package is missing dependencies in pyproject.toml Feb 18, 2024
@vsoch
Copy link
Collaborator

vsoch commented Feb 18, 2024

@w8jcik this plugin isn't properly working yet, and I'm not familiar enough with the refactored interface to work on it, so any contribution you might make would be appreciated!

@w8jcik
Copy link
Author

w8jcik commented Feb 18, 2024

I believe that this is missing from pyproject.toml

[tool.poetry.dependencies]
...
+ snakemake-interface-common = "^1.14.2"
+ snakemake-interface-storage-plugins = "^3.0.0"

Although I don't know the required version of snakemake-interface-common.

Both packages are imported here https://github.com/snakemake/snakemake-storage-plugin-gcs/blob/main/snakemake_storage_plugin_gcs/__init__.py#L3

@vsoch
Copy link
Collaborator

vsoch commented Mar 5, 2024

Could you open a pull request?

@w8jcik
Copy link
Author

w8jcik commented Mar 6, 2024

I am not a user of Google Cloud Storage, I was just packaging Snakemake plugins for some package manager.

But maybe work of @jairav mentioned above solves this issue.

@jairav
Copy link
Contributor

jairav commented Mar 7, 2024

I have created a PR.

vsoch pushed a commit that referenced this issue Mar 8, 2024
@w8jcik w8jcik closed this as completed Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants