fix: use decimals of each strategy to calculate voting power #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaituVR
changed the title
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no suggestions.
Sekhmet
previously requested changes
Dec 10, 2024
Sekhmet
dismissed
their stale review
I authored alternative implementation, won't review it as it's my code.
|
@ChaituVR I update this implementation, now it should work for both offchain and onchain spaces - as I dug deeper it turned out it needed different approach than what I suggested initially. Updated PR description with current implementation details. Would be great to have you review this change, and test it, from my side it can get merged after you and @wa0x6e approve it. |
In case of onchain strategies decimals are only there to specify how strategy value should be formatted, but it doesn't have effect on how this value is interpreted (strategy with VP value of 1 and 18 decimals and strategy with VP value of 1 and 0 decimals are actually the same and give sum of 2 VP). We need to separate cumulativeDecimals (used to calculate cumulative VP) and displayDecimals (used to display specific strategy's value). Depending on the context one or another needs to be used.
Sekhmet
force-pushed
the
fix-use-decimals-of-each-strategy
branch
from
7484aa0 to
576170f
Compare
wa0x6e
reviewed
Dec 16, 2024
apps/ui/src/views/Proposal.vue
Outdated
| @@ -310,7 +310,7 @@ watchEffect(() => { | |||
| <a | |||
| v-if=" | |||
| votingPower?.status === 'success' && | |||
| votingPower.totalVotingPower === BigInt(0) | |||
| votingPower.votingPowers.some(v => v.value > 0n) | |||
There was a problem hiding this comment.
Wouldn't that show when only one strategies among n strategies have 0 VP, but user still have enough VP to vote ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In case of onchain strategies decimals are only there to specify how
strategy value should be formatted, but it doesn't have effect on how
this value is interpreted (strategy with VP value of 1 and 18 decimals and
strategy with VP value of 1 and 0 decimals are actually the same and give sum
of 2 VP).
We need to separate cumulativeDecimals (used to calculate cumulative VP) and
displayDecimals (used to display specific strategy's value).
Depending on the context one or another needs to be used.
Closes: #1036
How to test
Onchain
0x556B14CbdA79A36dC33FcD461a04A5BCb5dC2A70Offchain
0x74fa01a5D0ef8039f1E14F4d4C8f90e8602e07B4