Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle transactions through Safe app #1041

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Sekhmet
Copy link
Member

@Sekhmet Sekhmet commented Dec 10, 2024

Summary

This PR changes three things when executing actions through Safe.

  1. When doing any action on EVM spaces (voting, proposing, editing settings) UI will not be blocked and you will be asked to confirm transaction in Safe app.
  2. When voting or proposing on Starknet spaces UI will not be blocked and you will be asked to confirm transaction in Safe app and also have access to hash-verifier.

Closes: https://github.com/snapshot-labs/workflow/issues/292

How to test

  1. On offchain spaces you can vote and propose and edit settings via Safe.
  2. On onchain EVM space you can vote, propose, and edit settings via Safe (non blocking, no hash-verifier link).
  3. On onchain Starknet space you can vote and propose via Safe (non blocking, hash-verifier link).

Screenshots

image

Wasn't sure about design on this screen or text to use there, so I'm open for suggestions.

@Sekhmet Sekhmet requested review from bonustrack and pscott December 10, 2024 15:06
@Sekhmet Sekhmet marked this pull request as ready for review December 10, 2024 15:06
@pscott
Copy link
Contributor

pscott commented Dec 10, 2024

I think it would make sense to have support for propose and updateSettings, basically any action that requires going back and forth between snapshot and safe :)

@Sekhmet Sekhmet changed the title feat: handle votes through Safe app feat: handle votes and proposals through Safe app Dec 10, 2024
@bonustrack
Copy link
Member

How is the flow with Snapshot offchain? Would be great to have similar modals

@Sekhmet Sekhmet changed the title feat: handle votes and proposals through Safe app feat: handle transactions through Safe app Dec 12, 2024
@Sekhmet
Copy link
Member Author

Sekhmet commented Dec 12, 2024

Should be ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants