-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handle transactions through Safe app #1041
Open
Sekhmet
wants to merge
7
commits into
master
Choose a base branch
from
sekhmet/safe-vote
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it would make sense to have support for |
Sekhmet
changed the title
feat: handle votes through Safe app
feat: handle votes and proposals through Safe app
Dec 10, 2024
Sekhmet
force-pushed
the
sekhmet/safe-vote
branch
from
December 10, 2024 15:46
4475bdb
to
1d95a6d
Compare
How is the flow with Snapshot offchain? Would be great to have similar modals |
Sekhmet
force-pushed
the
sekhmet/safe-vote
branch
from
December 12, 2024 16:06
3288a45
to
d6ec0fa
Compare
Sekhmet
changed the title
feat: handle votes and proposals through Safe app
feat: handle transactions through Safe app
Dec 12, 2024
Should be ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes three things when executing actions through Safe.
Closes: https://github.com/snapshot-labs/workflow/issues/292
How to test
Screenshots
Wasn't sure about design on this screen or text to use there, so I'm open for suggestions.