Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: proxy thegraph request via subgrapher #1052

Merged
merged 2 commits into from
Dec 16, 2024
Merged

fix: proxy thegraph request via subgrapher #1052

merged 2 commits into from
Dec 16, 2024

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Dec 13, 2024 •
edited
Loading

Summary

Closes: https://github.com/snapshot-labs/workflow/issues/331

This PR will proxy the network requests to thegraph.com via our subgrapher service, to avoid rate limit on queries without API keys

How to test

  1. Open network tab in the dev panel
  2. Go to http://localhost:8080/#/explore?p=snapshotx&n=all
  3. It should onchain spaces
  4. Filter the spaces by network
  5. It should load the spaces only for the specific network
  6. In the dev panel, you should see requests to subgrapher instead of thegraph.com directly

@wa0x6e wa0x6e marked this pull request as ready for review December 13, 2024 15:38
bonustrack
bonustrack approved these changes Dec 15, 2024
View reviewed changes
Copy link
Member

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@bonustrack bonustrack merged commit b63c672 into master Dec 16, 2024
1 check passed
@bonustrack bonustrack deleted the fix-use-subgrapher-links branch December 16, 2024 13:12
Sekhmet
Sekhmet reviewed Dec 17, 2024
View reviewed changes
Copy link
Member

@Sekhmet Sekhmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

postmerge utACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sekhmet Sekhmet Sekhmet left review comments

@bonustrack bonustrack bonustrack approved these changes

@ChaituVR ChaituVR Awaiting requested review from ChaituVR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wa0x6e @Sekhmet @bonustrack