Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add download votes button #1059

Merged
merged 1 commit into from
Dec 20, 2024
Merged

feat: add download votes button #1059

merged 1 commit into from
Dec 20, 2024

Conversation

Sekhmet
Copy link
Member

@Sekhmet Sekhmet commented Dec 17, 2024

Summary

This PR adds functionality to download votes for s spaces.

UI is temporary as it wasn't specified in the issue, but functionality should be good.

Currently server returns bad response while report is generated (doesn't return PENDING_GENERATION).
This PR contains workaround to handle that response:

{
    "jsonrpc": "2.0",
    "result": "0",
    "id": "0x345d62b550421b53c717ca2ca9b3edd4ebe6a4c12cef0ed26493d5164c22c4c6"
}

Closes: https://github.com/snapshot-labs/workflow/issues/336

How to test

  1. Go to offchain (s) space.
  2. Go to proposal that has passed.
  3. Try downloading it.
  4. You will get notification if it's still pending or it will prompt you to download report if it's ready.

Screenshots

Current UI:
image

@Sekhmet Sekhmet requested a review from bonustrack December 17, 2024 12:47
Copy link
Member

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@Sekhmet Sekhmet merged commit 91bdb3e into master Dec 20, 2024
2 checks passed
@Sekhmet Sekhmet deleted the sekhmet/add-download-votes branch December 20, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants