Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove delegation name for offchain spaces #923

Merged
merged 2 commits into from
Oct 23, 2024
Merged

feat: remove delegation name for offchain spaces #923

merged 2 commits into from
Oct 23, 2024

Conversation

Sekhmet
Copy link
Member

@Sekhmet Sekhmet commented Oct 22, 2024

Summary

Delegation name is ignored for offchain spaces.

Closes: #859

How to test

  1. Go to your offchain space settings.
  2. Add some delegation.
  3. There is no name input.

@Sekhmet Sekhmet requested review from wa0x6e and bonustrack October 22, 2024 16:33
wa0x6e
wa0x6e reviewed Oct 22, 2024
View reviewed changes
Copy link
Contributor

@wa0x6e wa0x6e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After adding a new delegation, but before saving, the "default" title is missing

Screenshot 2024-10-22 at 21 17 15

It appears after saving

Screenshot 2024-10-22 at 21 18 12

Title is infered from the delegation type, the unsaved delegation list should have same name as an already saved delegation

wa0x6e
wa0x6e approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@wa0x6e wa0x6e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@Sekhmet Sekhmet merged commit 0997e54 into master Oct 23, 2024
4 checks passed
@Sekhmet Sekhmet deleted the sekhmet/offchain-delegation-name branch October 23, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wa0x6e wa0x6e wa0x6e approved these changes

@bonustrack bonustrack Awaiting requested review from bonustrack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui: disable name input on offchain delegation form
2 participants
@Sekhmet @wa0x6e