Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove networks.json file #944

Merged
merged 3 commits into from
Nov 3, 2024
Merged

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Oct 25, 2024

Summary

Closes: #554
Depends on #943

This PR removes the networks.json file, which can be replaced by the one imported from snapshot.js SDK

How to test

  1. Everything work as before

@wa0x6e wa0x6e changed the title Fix-554-remove-networks-json refactor: remove networks.json file Oct 25, 2024
@wa0x6e wa0x6e marked this pull request as ready for review October 25, 2024 10:01
Base automatically changed from fix-remove-linea to master October 25, 2024 12:19
@wa0x6e wa0x6e requested a review from Sekhmet October 25, 2024 12:19
Copy link
Member

@Sekhmet Sekhmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@wa0x6e wa0x6e merged commit fe5d64d into master Nov 3, 2024
4 checks passed
@wa0x6e wa0x6e deleted the fix-554-remove-networks-json branch November 3, 2024 15:19
Sekhmet added a commit that referenced this pull request Nov 22, 2024
Sekhmet added a commit that referenced this pull request Nov 25, 2024
* feat: allow any network to be used in Treasuries

* fix: remove starknet networks from snapshotJS networks

Regression from #944
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: remove networks.json file
2 participants