Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close account modal on topnav unmount #966

Merged
merged 2 commits into from
Nov 4, 2024
Merged

fix: close account modal on topnav unmount #966

merged 2 commits into from
Nov 4, 2024

Conversation

ChaituVR
Copy link
Member

@ChaituVR ChaituVR commented Nov 4, 2024

Summary

Closes: https://github.com/snapshot-labs/workflow/issues/286

  • Close account modal when we go to landing page

How to test

  1. Go to http://127.0.0.1:8080/#/home
  2. Connect your wallet
  3. Click on Account button
    image
  4. Go to landing page http://127.0.0.1:8080/#/
  5. Come back to http://127.0.0.1:8080/#/home
  6. You should see modal before the fix, but not after

Sekhmet
Sekhmet approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@Sekhmet Sekhmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't reproduce but looks good to me.

@ChaituVR ChaituVR merged commit 7ac2541 into master Nov 4, 2024
3 of 4 checks passed
@ChaituVR ChaituVR deleted the fix-account-modal-close branch November 4, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sekhmet Sekhmet Sekhmet approved these changes

@wa0x6e wa0x6e Awaiting requested review from wa0x6e

@bonustrack bonustrack Awaiting requested review from bonustrack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChaituVR @Sekhmet