Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop routing special cases for Fake/OtherFake #1180

Closed
snarfed opened this issue Jul 13, 2024 · 1 comment
Closed

Drop routing special cases for Fake/OtherFake #1180

snarfed opened this issue Jul 13, 2024 · 1 comment
Labels
now

Comments

@snarfed
Copy link
Owner

snarfed commented Jul 13, 2024

We have a few special cases in routing logic in eg Protocol.targets and ids.translate_* for our test protocols like Fake and OtherFake, and those special cases occasionally hide bugs, eg #1179 just now. Ugh. We should refactor the tests that depend on them, and then remove them.
@snarfed snarfed added the now label Jul 15, 2024
snarfed added a commit that referenced this issue Oct 8, 2024
@snarfed
tests: remove routing special case for Fake and OtherFake in Protocol…
a5cbc9b 
….receive

for #1180
snarfed added a commit that referenced this issue Oct 11, 2024
@snarfed
tests: remove more Fake routing special cases in Protocol.targets, ha…
c648fb2 
…ndle_follow

for #1180
snarfed added a commit that referenced this issue Oct 11, 2024
@snarfed
tests: remove Fake/OtherFake special case in User.is_enabled
27afce3 
for #1180
snarfed added a commit that referenced this issue Oct 11, 2024
@snarfed
tests: remove Fake special case in Follower._pre_put_hook
feb4d4c 
for #1180
@snarfed
Copy link
Owner Author

snarfed commented Oct 11, 2024

Done!

@snarfed snarfed closed this as completed Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
now
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@snarfed