Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add craco support #2

Merged
merged 6 commits into from
Jul 4, 2021
Merged

Add craco support #2

merged 6 commits into from
Jul 4, 2021

Conversation

schettn
Copy link
Member

@schettn schettn commented Jul 4, 2021 •
edited
Loading

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change?
  • Have you tested your changes with successful results?

Type of Changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (non-breaking change which adds documentation)
  • Breaking change (fix or feature that would cause existing functionality to change)

What is the current behavior? (link to any open issues here)

What is the new behavior (if this is a feature change)?

Other information:

schettn added 2 commits July 4, 2021 20:35
@schettn
refactor(core): move all files from src to new core module
1777b35 
All files of src/ has been moved to src/core/ in order to support a development webserver (craco).
@schettn
feat(craco): add craco to test the core directly through a web server
28671bf 
Previously craco was located on a diffrent branch which resulted in duplicate commits.
Now craco will be directly integrated in the main branch, which benefits the development experience.
@schettn schettn requested a review from kleberbaum July 4, 2021 22:24
@schettn schettn self-assigned this Jul 4, 2021
schettn
schettn commented Jul 4, 2021
View reviewed changes
package.json Show resolved Hide resolved
kleberbaum
kleberbaum approved these changes Jul 4, 2021
View reviewed changes
Copy link
Member

@kleberbaum kleberbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok to merge.

schettn added 3 commits July 5, 2021 00:48
@schettn
chore(package.json/tsconfig.json): update ttsc decleration generation
93a7e0f 
The privouse commit disabled type generation because craco requires noEmit.
 This change updates the `build:types` script.
@schettn
chore(eslint): re-enable eslint support
0e90aae 
Due to the privouse changes of .tsconfig include section, eslint could not run on src/examples.
 A seperate tsconfig.eslint.json has been added to cope this issue.
@schettn
chore(card block): update link from a to button html element
032a4e8 
A button is a better placeholder link than a because href="#" on a does not fit with eslint rules.
@schettn schettn force-pushed the add-craco-support branch from c29d61c to 032a4e8 Compare July 4, 2021 22:49
@schettn
chore(home page): updated link in IndexField renderItem function
6a6ecb4 
Because no href is provided to the a tag, a button is the better choice.
@schettn schettn merged commit 295d619 into main Jul 4, 2021
@github-actions
Copy link

github-actions bot commented Jul 4, 2021

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@schettn schettn deleted the add-craco-support branch July 17, 2021 09:17
kleberbaum pushed a commit to getcronit/jaen-v3 that referenced this pull request Aug 8, 2024
@schettn
Merge pull request snek-at#2 from getcronit/main
cdcf90a 
fix: build index for dist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kleberbaum kleberbaum kleberbaum approved these changes

Assignees

@schettn schettn

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schettn @kleberbaum