Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed asset model query in action log transformer #13509

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

marcusmoore
Copy link
Collaborator

Description

This PR updates the asset model query to include trashed models to ensure the action log can be rendered properly.

This is a quick fix and there might be additional follow up fixes in the near future but this works for me.

Fixes #13508

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@what-the-diff
Copy link

what-the-diff bot commented Aug 23, 2023

PR Summary:

  • Improvement to AssetModel Search Functionality
    The search functionality in ActionlogsTransformer.php was adjusted to continue finding assets even after they've been removed. This allows us to retrieve and utilize information on 'soft deleted' models, which are those archived or deleted temporarily.

  • ID and Model Name Concatenation
    The system now combines model IDs with their corresponding names. This incremental change aids in obtaining more comprehensive and insightful data regarding our assets, enhancing clarity.

  • Modification in the Value Assignment of the 'Model' Key
    The Model key within the clean_meta array now systematically links to the value of model_id. This help ensures that the Model key is always updated with the correct and latest ID, thereby enhancing data consistency within the system.

@marcusmoore marcusmoore requested a review from Godmartinz August 23, 2023 00:13
@snipe snipe merged commit 31a7758 into snipe:develop Aug 23, 2023
@masjohan
Copy link

masjohan commented Aug 23, 2023 via email

@snipe
Copy link
Owner

snipe commented Aug 23, 2023

@masjohan That’s not how Github works :( You’ll probably have to login to the website and stop “watching” the the thread or the repo.

@marcusmoore marcusmoore deleted the bug/sc-23636 branch August 23, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants