-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Livewire to v3 #14831
Updated Livewire to v3 #14831
Conversation
# Conflicts: # app/Livewire/LoginForm.php # package.json # resources/views/livewire/login-form.blade.php
PR Summary
These changes, overall, update the Livewire dependency, restructure the project a bit, streamline the configuration settings and improve user interface behavior. |
| | ||
*/ | ||
|
||
'render_on_redirect' => false, | ||
|
||
'pagination_theme' => 'tailwind', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't use tailwind tho?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have any components that are using pagination yet so I skipped that because it is possible to use bootstrap but it is the latest version so I would have to downgrade it to bootstrap v3's syntax.
I figured I'd skip that until we actually need pagination but maybe I should just include it so we don't have to worry about it in the future...
Gonna move this back to draft and include that...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, you're right - we don't actually use Laravel pagination anywhere. You could probably just let it sit, since v8 will either be filament, OR will be just be more of our own API, which doesn't use UI pagination.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point...gonna leave this alone and just focus on the conflicts.
@marcusmoore assuming we're still moving forward with v7 on Monday, do you want to pull this in for launch, or wait until any v7 bugs have shaken themselves out? |
(And that importer merge just caused a conflict, so... sigh.) |
@snipe I'll handle the swap to bootstrap and the conflicts. I'm ok with it being included in v7.0.0 as long as I get the changes done in time. |
@snipe conflicts resolved but let's hold off on including it in Monday's release until we get some other people pulling it down and testing it. I think it's good to go but would like other eyes on it to make sure I didn't miss something. It's affecting a good amount of functionality. |
@marcusmoore that's really reasonable. Will do, thank you. |
# Conflicts: # resources/views/livewire/oauth-clients.blade.php
This is ready for review (and testing) now. |
# Conflicts: # composer.lock
# Conflicts: # composer.lock
@snipe just resolved some composer conflicts and this is ready for review/testing. To test this branch:
These are the components/pages that are affected by this PR:
|
Hm. In testing this locally, I'm getting
I'll see if I can get to the bottom of it before you come online. (I built assets and ran composer install, of course) |
Aaaaaand now I can't reproduce it. WTF. |
Seeing it pop up on the dev demo. Will try to manually clear those caches. |
For any future reader: the fix is |
Description
This PR updates Livewire from v2 to v3.
I started with the automated upgrader before moving on to the manual changes that needed to be made.
Notables:
App\Livewire
so our existing components have been moved there.package.json
since it is bundled with Livewire now. Since it is used in the new label engine I added@livewireScripts
to that page. Any future pages that use Alpine but not Livewire will need to have that added.legacy_model_binding
to be turned on but I would like to change that back to the default in the future.wire:model.live
s that can probably havelive
removed but that's a small change that can happen in the future.To test this make sure you:
composer install
nvm use
npm run dev
Please test thoroughly to double-check I didn't miss something.
The pages affected:
/account/api
/admin/oauth
/admin/slack
/categories/create
and/categories/{id}/edit
/import
/models/create
and/models/{id}/edit
Type of change