Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible fix for #14915 - error on import when status label is not provided and no deployable statuses can be found #14924

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jun 20, 2024

I'm not 100% sure this is the best way to handle this tbh, but if you don't provide us with a status label, it's tough for us to "guess" which status label you want, but we still need one, since all assets require that.

This should make it so that we get a status label so we have a value, and then try to pick a deployable one. This should only fire if you have no provided a status label in your CSV import.

Possible fix for #14915.

Signed-off-by: snipe <snipe@snipe.net>
Copy link

what-the-diff bot commented Jun 20, 2024

PR Summary

  • Introduction of a new property in AssetImporter
    The AssetImporter now possesses an additional property known as $defaultStatusLabelId. It's a piece of internal software configuration that will allow us to manage the status labels for our digital assets more effectively.

  • Modification in condition-checking process for setting the new property
    The condition for allotting values to the $defaultStatusLabelId property has been modified. This alteration makes the software more responsive and adaptable to various situations in the lifecycle of digital assets.

Signed-off-by: snipe <snipe@snipe.net>
Copy link
Collaborator

@marcusmoore marcusmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to make sense. I threw some data at it and it works as I'd expect.

@snipe snipe merged commit 665aa6e into develop Jun 21, 2024
8 checks passed
@snipe snipe deleted the fixes/possible_nicer_handling_for_defaultStatusLabel branch June 21, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants