Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next try accessories to locations rebased #15973

Merged

Conversation

uberbrady
Copy link
Collaborator

@uberbrady uberbrady commented Dec 16, 2024

This is a rebase of @snipe 's PR (#15913) so that it might be able to be applied more cleanly. Just need to put this up so she can look at it.

snipe added 21 commits December 16, 2024 16:34
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Copy link

what-the-diff bot commented Dec 16, 2024

PR Summary

  • Improved Code Structure

    • Changes were made to how created_by is assigned and handling of request input in the AccessoryCheckoutController.php. Also, changes in the method signatures, pagination handling in Api/AccessoriesController.php, and addition of new methods for retrieval purposes in Api/AssetsController.php and Api/LocationsController.php.
    • New transformation method introduced in Transformers/AccessoriesTransformer.php and Transformers/AssetsTransformer.php for a structured way of handling data.
  • Streamlined Presentation and Translation

    • A new compact user data representation method transformUserCompact was added in UsersTransformer.php. Formatting changes in AccessoryCheckout.php for improved readability and clarity.
    • Addition of new relationships in AccessoryCheckout.php, new methods in Location.php for managing accessory assignments, and updated method in User.php.
    • Introduced new ways for enhanced data presentation in AccessoryPresenter.php and added Portuguese translation file for the datepicker functionality for user experience improvement.
  • CSS Modifications for Improved Performance

    • Minified CSS versions were created for signature-pad, skin-black for better performance. Relevant modifications in skin-blue.css, skin-contrast.css, skin-green.css, skin-orange.css, skin-purple.css, skin-red.css, and skin-yellow.css were done to improve loading time and preserve visual themes.
  • License and Version Updates

    • Updated jQuery UI version and newly added LICENSE.txt file in all.js distribution. Binary font files were also updated in the webfonts directory.
  • Frontend and Testing Enhancements

    • The mix-manifest.json was updated to reflect new hashed file names for assets. Adjustments to icon display properties and localization changes were made for better UI.
    • View enhancements in checkout.blade.php and view.blade.php along with removal of deprecated code in locations/index.blade.php.
    • New API routes added and refactor of test cases in LocationsViewTest.php for a more robust application.

@snipe snipe merged commit 04c3481 into snipe:develop Dec 16, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants