Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow user to pass list of groups to be mapped to single flag type #104

Closed

Conversation

knightkd
Copy link

No change to original functionality and it adds the ability to pass in a list to GROUP_TO_FLAG_MAPPING.

This is useful for companies like mine that have many different managed security groups and may need to associate more than one group with a single flag.

example usage:
{"GROUP_TO_FLAG_MAPPING": { "is_staff": ["ALL_RWILLIAMS_DIRECT_EMPLOYEES", "ALL_SEDWARDS_DIRECT_EMPLOYEES"], "is_superuser": "APP_ADMIN_GROUP"}}

@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #104 into master will decrease coverage by 0.39%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
- Coverage   82.77%   82.38%   -0.40%     
==========================================
  Files           7        7              
  Lines         418      420       +2     
==========================================
  Hits          346      346              
- Misses         72       74       +2     
Impacted Files Coverage Δ
django_auth_adfs/backend.py 79.74% <0.00%> (-1.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41fa2b8...0f9a4d4. Read the comment docs.

@JonasKs
Copy link
Member

JonasKs commented Jan 16, 2021

Hi! (Read #121 for some background on why this have had no replies)

Could you add a test and docs for this? 😄

@joachimBurket
Copy link
Contributor

Hi! We are also interested in passing a list of groups to a single flag type in my team.
@knightkd are you still interested in finishing it ? Otherwise I can add a test and update the doc for it to be merge :)

@JonasKs
Copy link
Member

JonasKs commented Jul 29, 2021

Since it's been stale I'm sure you can branch out from this and add tests+docs and I'll merge in the correct order. 😊

joachimBurket pushed a commit to joachimBurket/django-auth-adfs that referenced this pull request Jul 30, 2021
@JonasKs
Copy link
Member

JonasKs commented Aug 13, 2021

Solved in #172. Thank you for your contribution! 🎉

@JonasKs JonasKs closed this Aug 13, 2021
JonasKs added a commit that referenced this pull request Aug 14, 2021
Implementation, tests and docs of pull request #104
mmcclelland1002 pushed a commit to mmcclelland1002/django-auth-adfs that referenced this pull request Nov 12, 2021
mmcclelland1002 pushed a commit to mmcclelland1002/django-auth-adfs that referenced this pull request Nov 12, 2021
Implementation, tests and docs of pull request snok#104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants