Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs #129

Merged
merged 4 commits into from
Aug 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
matrix:
os: [ ubuntu-latest, macos-latest, windows-latest ]
python-version: [ "3.7", "3.8", "3.9", "3.10", "3.11" ]
poetry-version: [ "1.1.15", "1.2.2", "1.3.2" ]
poetry-version: [ "1.1.15", "1.2.2", "1.3.2", "1.4.2", "1.5.1" ]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
Expand Down Expand Up @@ -50,14 +50,14 @@ jobs:
python-version: "${{ matrix.python-version }}"
- uses: ./
with:
version: 1.3.2
version: 1.5.1
virtualenvs-create: false
virtualenvs-in-project: true
virtualenvs-path: ~/.cache/test
installer-parallel: false
- run: |
source .github/scripts/assert.sh
assert_in "1.3.2" "$(poetry --version)"
assert_in "1.5.1" "$(poetry --version)"
assert_in "false" "$(poetry config virtualenvs.create)"
assert_in "true" "$(poetry config virtualenvs.in-project)"
assert_in "test" "$(poetry config virtualenvs.path)"
Expand Down Expand Up @@ -105,5 +105,5 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: snok/install-poetry@v1
- uses: snok/install-poetry@v1.1
- uses: snok/install-poetry@v1.2
- uses: snok/install-poetry@v1.3
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ repos:
- id: mixed-line-ending

- repo: https://github.com/sirosen/check-jsonschema
rev: 0.21.0
rev: 0.23.3
hooks:
- id: check-github-actions
- id: check-github-workflows
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ If you want to set Poetry config settings, or install a specific version, you ca
- name: Install and configure Poetry
uses: snok/install-poetry@v1
with:
version: 1.3.2
version: 1.5.1
virtualenvs-create: true
virtualenvs-in-project: false
virtualenvs-path: ~/my-custom-path
Expand All @@ -31,7 +31,7 @@ If you want to set Poetry config settings, or install a specific version, you ca

If you need to pass extra arguments to the installer script, you can specify these with `installation-arguments`.

The action is fully tested for MacOS and Ubuntu runners, on Poetry versions >= 1.1. If you're using this with Windows, see the [Running on Windows](#running-on-windows) section.
The action is fully tested for macOS and Ubuntu runners, on Poetry versions >= 1.1. If you're using this with Windows, see the [Running on Windows](#running-on-windows) section.

## Defaults

Expand Down Expand Up @@ -422,7 +422,7 @@ There are two other relevant scenarios:

If you're using the default settings, the venv location changes from `.venv` to using `{cache-dir}/virtualenvs`. You
can also change the path to whatever you'd like. Generally though, this can make things a little tricky, because the
directory will be vary depending on the OS, making it harder to write OS agnostic workflows.
directory will be vary depending on the OS, making it harder to write OS-agnostic workflows.

A solution to this is to bypass this issue completely by taking advantage of Poetry's `poetry run` command.

Expand Down