SNOW-1563083: snowflakeConn creates/manages its own context #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
joellubi
changed the title
|
I have read the CLA Document and I hereby sign the CLA |
joellubi
changed the title
Closed
2 tasks
|
@joellubi Thank you for the contribution! You're actually right, we shouldn't propagate the context to build the connection. I'm running this PR against our CI tests and we'll get back to you (probably on Friday). |
sfc-gh-dheyman-1
approved these changes
Aug 16, 2024
sfc-gh-pbulawa
approved these changes
Aug 20, 2024
|
Hi @joellubi, sorry for the delay - there were some issues with one of our CI tests environments but these are fixed and all tests are passing. This will be released in the upcoming version later this month. Thank you once again for the contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SNOW-1563083 Avoid persisting query context in
snowflakeConn, using it only for dialing purposes as described in docs.Fixes: #1186
Checklist