[SNOW-1669514] Honor the Valuer/Stringer methods to resolve #1209 #1211
Conversation
ChronosMasterOfAllTime
changed the title
ChronosMasterOfAllTime
changed the title
ChronosMasterOfAllTime
changed the title
| return bindingValue{}, nil | ||
| } else if stringer, ok := v1.Interface().(fmt.Stringer); ok { // alternate approach; check for stringer method. Guarantees it's String() and returns string | ||
| value := stringer.String() | ||
| return bindingValue{&value, "", nil}, nil | ||
| } | ||
| res, err := json.Marshal(v) |
There was a problem hiding this comment.
After this, the bindingValue is set to "json". Should that be the case, or should it be string? Since it is already Marshaled, why set it to json again? That will cause it to be marshaled a second time. It feels like it should not marshal here if it also sets the binding value to json.
There was a problem hiding this comment.
to be clear This is in reference to the code on Lines 406-409; the added code will not return the "json" string as it's already been transformed
| // if the output value is a valid string, return that | ||
| if strVal, ok := value.(string); ok { | ||
| return bindingValue{&strVal, "", nil}, nil | ||
| } |
There was a problem hiding this comment.
Leaving this here as a suggestion; did we want to let a marshaler handle the driver's value if not a string by default?
EDIT: The below suggestion would break sql.NullTime. Tests pass if we dont use the below suggestion. This is unless we don't want the expectation to be Epoch Time for this case?
| } | |
| } else if marshaled, err := json.Marshal(value); err == nil { | |
| value := string(marshaled) | |
| return bindingValue{&value, jsonFormatStr, nil}, nil | |
| } |
| @@ -28,6 +28,7 @@ import ( | |||
|
|
|||
| const format = "2006-01-02 15:04:05.999999999" | |||
| const numberDefaultPrecision = 38 | |||
| const jsonFormatStr = "json" | |||
There was a problem hiding this comment.
@sfc-gh-dszmolka can you please explain how the format string is being used by the execBindQuery struct, or what is the purpose of this field?
ChronosMasterOfAllTime
changed the title
Description
SNOW-1669514 - Solve the issue with UUID getting double quoted due to new array function #1209
This adds the ability to check the valuer/stringer interfaces exists
Checklist
Proof test fails.